Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #34. Support Python >= 3.10 #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PaoloAlbano
Copy link

@PaoloAlbano PaoloAlbano commented Mar 22, 2023

Description of change

Conditional import of of module collections on python version

Description of change

Run on python >=3.10.
Conditional import on collections

Risks

...

Rollback steps

  • revert this branch

@singer-bot
Copy link

Hi @PaoloAlbano, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@PaoloAlbano PaoloAlbano changed the title Fix issue #34. Conditional import of module collections Fix issue #34. Support Python >= 3.10 Mar 27, 2023
@m-birke
Copy link

m-birke commented May 22, 2024

whats the state here ... python 3.13 is about to hatch and csv standard target does not work above 3.9, why is the csv target not maintained anymore?

@frasermarlow
Copy link

frasermarlow commented Jun 4, 2024

whats the state here ... python 3.13 is about to hatch and csv standard target does not work above 3.9, why is the csv target not maintained anymore?

@PaoloAlbano needs to accept the CLA first before the Qlick/Stitch/Singer team reviews the PR. If you are running into the MutableMapping issue I posted a workaround here: #34 (comment)

@PaoloAlbano
Copy link
Author

@frasermarlow I have already accepted the CLA and it is already marked as delivered.

@singer-bot
Copy link

You did it @PaoloAlbano!

Thank you for signing the Singer Contribution License Agreement.

@m-birke
Copy link

m-birke commented Jun 19, 2024

merge & release pls, thanks

@m-birke
Copy link

m-birke commented Oct 18, 2024

merge & release pls, thanks

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants